snowflakedb / gosnowflake

Go Snowflake Driver
Apache License 2.0
292 stars 122 forks source link

SNOW-1006312: Cancel context not propagated to snowflakeFileTransferAgent on PUT/GET command #1108

Closed sfc-gh-ext-simba-jl closed 1 week ago

sfc-gh-ext-simba-jl commented 4 months ago

Description

issue 822: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/822 Context not propagated to snowflakeFileTransferAgent on PUT/GET command; cancellation is not supported

This PR fixes the issue by adding ctx to snowflakeFileTransferAgent and adding a channel to detect if the file transfer process has been cancelled during processFileTransfer.

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.46%. Comparing base (aa4b7cd) to head (f7c393f). Report is 1 commits behind head on master.

Files Patch % Lines
connection.go 84.61% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1108 +/- ## ========================================== - Coverage 82.48% 82.46% -0.03% ========================================== Files 54 54 Lines 12832 12916 +84 ========================================== + Hits 10585 10651 +66 - Misses 2247 2265 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.