search

snowflakedb / gosnowflake

Go Snowflake Driver
Apache License 2.0
292 stars 122 forks source link

Upgrade AWS SDK packages to the latest version #1125

Closed evan-bradley closed 4 months ago

evan-bradley commented 4 months ago

Description

Hello!

I am a maintainer on a project that uses the Go Snowflake driver to ingest data from snowflake: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/snowflakereceiver#snowflake-receiver

We recently discovered that another module in our application uses a newer version of the Go AWS SDK library which appears to have type changes that conflict with the version used here. This PR upgrades the library to the latest version without introducing any code changes. I was unable to run any tests locally due to the setup required, but I did compile our application with a replace statement that links to these changes to determine that the code still builds. I will rely on CI to determine that everything still works, but can do the necessary setup to test locally if there are issues.

Checklist

github-actions[bot] commented 4 months ago


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

evan-bradley commented 4 months ago

I'm reaching out internally about signing the CLA. I will mark this PR as a draft until I get confirmation I can sign it.

sfc-gh-pfus commented 4 months ago

Hi @evan-bradley ! Thank you for your contribution. We can wait for your confirmation on CLA and in the meantime I started CI builds. You can observe results. Stay tuned!

evan-bradley commented 4 months ago

Thank you for taking a look @sfc-gh-pfus! Unfortunately, I don't think I will hear back in time to make a change this small worth the wait. I'm going to close this and the upgrades can be done in https://github.com/snowflakedb/gosnowflake/pull/1126, or a follow-up from you or another contributor. It appears CI is green for everything but the CLA check, so I think the upgrades should be smooth. Thanks again.

sfc-gh-pfus commented 4 months ago

Thank you @evan-bradley for your attempt to make gosnowflake better! As we already have everything we need, I'll merge #1126 .