Improved arrow tests - Githubissues

snowflakedb / gosnowflake

Go Snowflake Driver

Apache License 2.0

285 stars 116 forks source link

Improved arrow tests #1172

Closed sfc-gh-astachowski closed 2 weeks ago

sfc-gh-astachowski commented 2 weeks ago

Description

SNOW-1522375 Made two changes to arrow-test.go:

moved repetitive code from TestArrowTimePrecision to for loops
changed selectVariousTypes query so TestArrowVariousTypes would be independent from environment it's ran in (other test using this query pass)

Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

github-actions[bot] commented 2 weeks ago

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.16%. Comparing base (52590b9) to head (1e87b1c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1172 +/- ## ======================================= Coverage 83.16% 83.16% ======================================= Files 54 54 Lines 12149 12149 ======================================= Hits 10104 10104 Misses 2045 2045 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.