search

snowflakedb / pdo_snowflake

PHP PDO driver for snowflake
Apache License 2.0
59 stars 30 forks source link

SNOW-1039347: update libsnowflakeclient 1.0.7 #366

Closed ghost closed 6 months ago

ghost commented 6 months ago

sdk issue 858 update libsnowflake 1.0.7 with all dependencies include fix in https://github.com/snowflakedb/pdo_snowflake/pull/334 as well

ghost commented 6 months ago

Additionally:

  1. can we remove cmocka dependency? we probably don't need it as we run only php tests
  2. *.h files are the same for all dependencies - can we add them once?

I actually tried removing cmocka and test failed on Linux. Didn't take a close look on the root cause though. For header files from dependencies I think it might not even needed. But since it's been there for years better no to make change on that right before release.