search

snowflakedb / pdo_snowflake

PHP PDO driver for snowflake
Apache License 2.0
59 stars 30 forks source link

SNOW-1367604: Add PHP 8.3 Support #382

Closed aldobarr closed 2 months ago

aldobarr commented 4 months ago

What is the current behavior?

PHP 8.3 is not supported

What is the desired behavior?

PHP 8.3 is supported

How would this improve pdo_snowflake?

PHP 8.3 is already starting to be upgraded to by many production environments. However any system relying on snowflake is unable to do so.

References, Other Background

N/A

What is your Snowflake account identifier, if any?

N/A

salvor-hardin commented 4 months ago

I have php 8.3.6 and this driver has worked fine every version of 8.3.x

aldobarr commented 4 months ago

I have php 8.3.6 and this driver has worked fine every version of 8.3.x

Hm, it did not compile for me, also PHP 8.3 is not explicitly stated in the readme while other versions are specifically called out which led me to believe that it's not supported

sfc-gh-dszmolka commented 4 months ago

hi there - thank you for your interest in this driver and adding PHP8.3 support ! Coincidentally, it's already something on the table :) so we definitely planning to do it. Timeline-wise, I'll need to confirm it with the team internally. Will update this thread once any information is available on the expected timeline.

edit: estimated delivery for official PHP8.3 support is May (end of month); but the main branch should work with PHP8.3 even now if someone would feel like trying.

sfc-gh-dszmolka commented 3 months ago

(relevant PR is https://github.com/snowflakedb/pdo_snowflake/pull/383, already merged, waiting for release)

edit: release is expected to be available towards mid June 2024

sfc-gh-dszmolka commented 2 months ago

PHP 8.3 support released with v3.0.0 (and PHP 8.0 deprecated)