search

snowflakedb / pdo_snowflake

PHP PDO driver for snowflake
Apache License 2.0
62 stars 29 forks source link

SNOW-1452220: VS2019 no longer available - Could not determine 'vs16' directory #386

Closed MaxenceSAUNIER closed 4 months ago

MaxenceSAUNIER commented 4 months ago

  1. What version of PDO/PHP driver are you using? 8.2.18

  2. What operating system and processor architecture are you using? x64 Windows 11

  3. What version of C/C++ compiler are you using? Microsoft Visual C++ 2015-2019 Redistribuable (x64) - 14.29.30153

  4. What did you do?

I have follow « Building the Driver on Windows » steps. At the step « 4. Download and build the PHP source code. » I have this error:

>> .\scripts\run_setup_php.bat x64 Release VS16 8.2.18 .\php-sdk
=== setting up global environment variables
"Building with platform: x64, build type: Release, visual studio version: VS16, cmake generator: Visual Studio 16 2019"
Could not determine 'vs16' directory

Visual Studio 2019 (VS16) is no longer available for download https://my.visualstudio.com/Downloads?q=visual%20studio%202019&wt.mc_id=o~msft~vscom~older-downloads

  1. What did you expect to see?

  2. Can you set logging to DEBUG and collect the logs?

  3. What is your Snowflake account identifier, if any? (Optional)

sfc-gh-dszmolka commented 4 months ago

hi and thank you for reporting this; will take a look

sfc-gh-dszmolka commented 4 months ago

can you please check if downloading Visual Studio 2019 from https://learn.microsoft.com/en-us/visualstudio/releases/2019/redistribution#vs2019-download helps moving forward ?

MaxenceSAUNIER commented 4 months ago

It seems to download the correct version, I'll let you know as soon as I test.

MaxenceSAUNIER commented 4 months ago

It works like a charm, thanks you very much.

sfc-gh-dszmolka commented 4 months ago

perfect; thank you for testing it so quickly and the feedback - glad to hear it works. Closing this issue now.