snowflakedb / snowflake-connector-net

Snowflake Connector for .NET
Apache License 2.0
180 stars 138 forks source link

SNOW-1629635 fix connection pool allocation #1024

Closed sfc-gh-mhofman closed 2 months ago

sfc-gh-mhofman commented 2 months ago

Description

Fixed connection pool manager allocation problem Removal of exceptions related to optional connection string parameters

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.29897% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.68%. Comparing base (aef4d3a) to head (02aedf2).

Files with missing lines Patch % Lines
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 95.83% 3 Missing and 3 partials :warning:
Snowflake.Data/Core/Tools/Diagnostics.cs 87.50% 3 Missing and 2 partials :warning:
Snowflake.Data/Client/SnowflakeDbConnectionPool.cs 75.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1024 +/- ## ========================================== - Coverage 85.75% 85.68% -0.08% ========================================== Files 117 118 +1 Lines 11352 11400 +48 Branches 1133 1137 +4 ========================================== + Hits 9735 9768 +33 - Misses 1337 1350 +13 - Partials 280 282 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.