snowflakedb / snowflake-connector-net

Snowflake Connector for .NET
Apache License 2.0
180 stars 138 forks source link

SNOW-834781: Remove log4net and delegate logging to consumers #1057

Open sfc-gh-ext-simba-lf opened 2 weeks ago

sfc-gh-ext-simba-lf commented 2 weeks ago

Description

Remove the log4net dependency and replace with the Microsoft logging interface so users can plug in their own custom loggers

Checklist

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 83.20251% with 107 lines in your changes missing coverage. Please review.

Project coverage is 86.09%. Comparing base (296a281) to head (3f3a15c).

Files with missing lines Patch % Lines
...Core/Authenticator/ExternalBrowserAuthenticator.cs 6.25% 15 Missing :warning:
...lake.Data/Core/FileTransfer/SFFileTransferAgent.cs 46.42% 14 Missing and 1 partial :warning:
Snowflake.Data/Logger/SFLoggerEmptySimpleImpl.cs 50.00% 15 Missing :warning:
Snowflake.Data/Core/SFStatement.cs 35.00% 11 Missing and 2 partials :warning:
Snowflake.Data/Core/Session/SFSession.cs 68.96% 8 Missing and 1 partial :warning:
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 95.83% 3 Missing and 3 partials :warning:
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 25.00% 3 Missing :warning:
Snowflake.Data/Core/HttpUtil.cs 84.21% 2 Missing and 1 partial :warning:
Snowflake.Data/Core/Session/SFSessionProperty.cs 82.35% 3 Missing :warning:
Snowflake.Data/Client/SnowflakeDbConnection.cs 91.30% 2 Missing :warning:
... and 15 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1057 +/- ## ========================================== - Coverage 86.32% 86.09% -0.23% ========================================== Files 121 122 +1 Lines 11779 11808 +29 Branches 1197 1199 +2 ========================================== - Hits 10168 10166 -2 - Misses 1326 1355 +29 - Partials 285 287 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: