snowflakedb / snowflake-connector-net

Snowflake Connector for .NET
Apache License 2.0
173 stars 130 forks source link

SNOW-878067: Fix retry logic #866

Open sfc-gh-ext-simba-lf opened 4 months ago

sfc-gh-ext-simba-lf commented 4 months ago

Description

  1. Add extra check for retry timeout being infinite
  2. Check maxHttpRetries before creating the HttpClient

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.11%. Comparing base (9d61e81) to head (c10d13f). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #866 +/- ## ========================================== - Coverage 84.35% 84.11% -0.24% ========================================== Files 88 88 Lines 9336 9401 +65 Branches 874 885 +11 ========================================== + Hits 7875 7908 +33 - Misses 1235 1260 +25 - Partials 226 233 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.