Closed sfc-gh-knozderko closed 3 months ago
Attention: Patch coverage is 94.13490%
with 20 lines
in your changes are missing coverage. Please review.
Project coverage is 82.33%. Comparing base (
85204fc
) to head (db8130a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I would do one thing around _configOverriden. When user is changing tech config of any pool I would make a copy of the initial settings. You have all the means to make it simple - _poolConfig. Then within the setters whether it's a new value or previous (reverted) value you can compare initial config with the new one implementing Equals on the ConnectionPoolConfig. This way if only user reverts the changes to the pool, he will get rid of the false indication in the logs that something in the pool got changed.
Description
SNOW-902632 connection string driven pool config
Checklist
dotnet test
)