snowflakedb / snowflake-connector-net

Snowflake Connector for .NET
Apache License 2.0
177 stars 135 forks source link

SNOW-1271212 Fixed values uploaded to stage for bindings exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD #897

Closed sfc-gh-mhofman closed 6 months ago

sfc-gh-mhofman commented 6 months ago

Description

When number of binded values during query execution exceeds the threshold of a session parameter CLIENT_STAGE_ARRAY_BINDING_THRESHOLD then values are written as a CSV file to a stage and it get's picked during query excecution. Improper values (or values truncating fractions of ms) has been uploaded for date and time related columns of type: DATE, TIME, TIMESTAMP_LTZ, TIMESTAMP_NTZ, TIMESTAMP_TZ.

Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.70%. Comparing base (ac0860f) to head (db80eff). Report is 1 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Client/SnowflakeDbCommand.cs 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #897 +/- ## ========================================== + Coverage 84.41% 84.70% +0.28% ========================================== Files 89 89 Lines 9683 9681 -2 Branches 914 915 +1 ========================================== + Hits 8174 8200 +26 + Misses 1274 1253 -21 + Partials 235 228 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.