snowflakedb / snowflake-connector-net

Snowflake Connector for .NET
Apache License 2.0
173 stars 130 forks source link

SNOW-715524: Add SSO token cache #921

Open sfc-gh-ext-simba-lf opened 2 months ago

sfc-gh-ext-simba-lf commented 2 months ago

Description

Add SSO token cache

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 72.53521% with 78 lines in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (1465bda) to head (da0cffb). Report is 1 commits behind head on master.

Files Patch % Lines
...Core/Authenticator/ExternalBrowserAuthenticator.cs 0.00% 71 Missing :warning:
...astructure/SFCredentialManagerWindowsNativeImpl.cs 92.15% 2 Missing and 2 partials :warning:
...ager/Infrastructure/SFCredentialManagerFileImpl.cs 98.82% 0 Missing and 1 partial :warning:
...re/CredentialManager/SFCredentialManagerFactory.cs 95.83% 0 Missing and 1 partial :warning:
Snowflake.Data/Core/Session/SFSession.cs 95.23% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #921 +/- ## ========================================== + Coverage 85.43% 85.70% +0.26% ========================================== Files 106 110 +4 Lines 10761 10985 +224 Branches 1029 1052 +23 ========================================== + Hits 9194 9415 +221 + Misses 1318 1317 -1 - Partials 249 253 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rafael-sotelo commented 1 month ago

Any updates on this PR ? Can I help ? I been waiting for this SSO Token Cache for long time

sfc-gh-ext-simba-lf commented 1 month ago

Any updates on this PR ? Can I help ? I been waiting for this SSO Token Cache for long time

Currently we're trying out different libraries/packages for the credential manager. Then it'll be reviewed if it meets the security requirements