snowflakedb / snowflake-connector-net

Snowflake Connector for .NET
Apache License 2.0
173 stars 130 forks source link

[SNOW-1156046] fix toctou vulnerability in EasyLogginConfig #925

Open sfc-gh-erojaslizano opened 2 months ago

sfc-gh-erojaslizano commented 2 months ago

Description

Invert the order, first read the file and then check the permissions.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.75%. Comparing base (abb5c4a) to head (dc4f5b0).

:exclamation: Current head dc4f5b0 differs from pull request most recent head 9a2925b

Please upload reports for the commit 9a2925b to get more accurate results.

Files Patch % Lines
...lake.Data/Configuration/EasyLoggingConfigParser.cs 96.15% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #925 +/- ## ========================================== + Coverage 84.74% 84.75% +0.01% ========================================== Files 89 89 Lines 9709 9717 +8 Branches 921 920 -1 ========================================== + Hits 8228 8236 +8 Misses 1253 1253 Partials 228 228 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sfc-gh-erojaslizano commented 1 month ago

I have read the CLA Document and I hereby sign the CLA