SNOW-952788 remove support for node 14 and 16

snowflakedb / snowflake-connector-nodejs

NodeJS driver

Apache License 2.0

125 stars 132 forks source link

SNOW-952788 remove support for node 14 and 16 #934

Open sfc-gh-akolodziejczyk opened 1 month ago

sfc-gh-akolodziejczyk commented 1 month ago

Description

SNOW-952788

Checklist

[ ] Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
[ ] Create tests which fail without the change (if possible)
[ ] Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
[ ] Extend the README / documentation and ensure is properly displayed (if necessary)
[ ] Provide JIRA issue id (if possible) or GitHub issue id in commit message

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.89%. Comparing base (d7e518a) to head (1c3d145).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #934 +/- ## ========================================== - Coverage 89.06% 88.89% -0.18% ========================================== Files 66 66 Lines 6455 6455 ========================================== - Hits 5749 5738 -11 - Misses 706 717 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sfc-gh-pmotacki commented 1 month ago

The suggestion is to wait to remove builds for older versions until we release the driver and announce the end of support. WDYT @sfc-gh-akolodziejczyk ?

sfc-gh-akolodziejczyk commented 1 month ago

The suggestion is to wait to remove builds for older versions until we release the driver and announce the end of support. WDYT @sfc-gh-akolodziejczyk ?

Ok, let's wait