snowflakedb / snowflake-connector-nodejs

NodeJS driver
Apache License 2.0
125 stars 132 forks source link

SNOW-1346341: Consideration of PROXY*/NO_PROXY env variables in creation httpAgent. #938

Closed sfc-gh-ext-simba-jy closed 2 weeks ago

sfc-gh-ext-simba-jy commented 1 month ago

Description

Please explain the changes you made here.

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (c77f3d6) to head (f26430e).

Files with missing lines Patch % Lines
lib/file_transfer_agent/s3_util.js 87.50% 1 Missing :warning:
lib/http/node.js 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #938 +/- ## ========================================== + Coverage 88.94% 89.00% +0.05% ========================================== Files 67 67 Lines 6459 6510 +51 ========================================== + Hits 5745 5794 +49 - Misses 714 716 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.