search

snowflakedb / snowflake-connector-nodejs

NodeJS driver
Apache License 2.0
124 stars 132 forks source link

SNOW-1789663: Resolve `@aws-sdk/node-http-handler@3.374.0` NPM deprecation warning #947

Open dar-yl opened 1 week ago

dar-yl commented 1 week ago

Related - @azure/core-http@3.0.4 deprecation: https://github.com/snowflakedb/snowflake-connector-nodejs/issues/948

  1. What version of NodeJS driver are you using? 1.14.0

  2. What operating system and processor architecture are you using? N/A

  3. What version of NodeJS are you using? Node: 20.17.0 / NPM: 10.8.2

  4. What are the component versions in the environment (npm list)?

    sandbox@0.0.0
└── snowflake-sdk@1.14.0

  5. What did you do? Install the Node snowflake-sdk@1.14.0. Refer to NPM deprecation warnings...

    npm i snowflake-sdk@1.14.0
npm warn deprecated @aws-sdk/node-http-handler@3.374.0: This package has moved to @smithy/node-http-handler
# ...

  6. What did you expect to see? No deprecation warnings.

  7. Can you collect debug logs? N/A

sfc-gh-dszmolka commented 1 week ago

hi - thank you for drawing attention to this, not entirely sure why we need 2 separate issues but works for us. we'll look into this.

dar-yl commented 1 week ago

@sfc-gh-dszmolka thanks and no worries - I wasn't sure how you'd prefer to approach it, figured the safer default was to split the issues. Happy to merge the 2 if you would prefer.

sfc-gh-dszmolka commented 1 week ago

no worries , let's keep them separate for now, in case any issue with the dependency bump

sfc-gh-dszmolka commented 1 week ago

PR in draft https://github.com/snowflakedb/snowflake-connector-nodejs/pull/950

sfc-gh-dszmolka commented 6 days ago

PR merged, and will be part of the next version