search

snowflakedb / snowflake-connector-nodejs

NodeJS driver
Apache License 2.0
125 stars 132 forks source link

SNOW-1789666: Resolve NPM deprecation warning `@azure/core-http@3.0.4` #948

Open dar-yl opened 2 weeks ago

dar-yl commented 2 weeks ago

Related - @aws-sdk/node-http-handler@3.374.0 deprecation: https://github.com/snowflakedb/snowflake-connector-nodejs/issues/947

  1. What version of NodeJS driver are you using? 1.14.0

  2. What operating system and processor architecture are you using? N/A

  3. What version of NodeJS are you using? Node: 20.17.0 / NPM: 10.8.2

  4. What are the component versions in the environment (npm list)?

    sandbox@0.0.0
└── snowflake-sdk@1.14.0

  5. What did you do? Install the Node snowflake-sdk@1.14.0. Refer to NPM deprecation warnings...

    npm i snowflake-sdk@1.14.0
# ...
npm warn deprecated @azure/core-http@3.0.4: This package is no longer supported. Please migrate to use @azure/core-rest-pipeline

  6. What did you expect to see? No deprecation warnings.

  7. Can you collect debug logs? N/A

sfc-gh-dszmolka commented 2 weeks ago

hi - thank you for drawing attention to this, not entirely sure why we need 2 separate issues but works for us. we'll look into this.

sfc-gh-dszmolka commented 2 weeks ago

the deprecated package @azure/core-http comes as a transient dependency (from our pre-12.23.0 @azure/storage-blob) direct dependency) PR in draft https://github.com/snowflakedb/snowflake-connector-nodejs/pull/951

sfc-gh-dszmolka commented 2 weeks ago

tests on Azure node 14.x are failing, the upgraded library does not seem to support node:14 (needs node:18), so likely we'll need to wait until we deprecate node:14 . at this moment (7 November 2024) we still list under the supported runtimes.

putting this issue in blocked status until support for node:14 is dropped from Snowflake node.js driver.

edit: turned out that after all it was a good idea to create 2 separate issues for the aws and the azure library deprecations :)