search

snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
576 stars 467 forks source link

SNOW-777765: Interpolate empty sequences in queries by default #1497

Open timgraham opened 1 year ago

timgraham commented 1 year ago

What is the current behavior?

As part of https://github.com/snowflakedb/snowflake-connector-python/issues/961, the interpolate_empty_sequences connection parameter was added (https://github.com/snowflakedb/snowflake-connector-python/pull/997), defaulting to False for backward compatibilty.

What is the desired behavior?

The interpolate_empty_sequences=True behavior should be the default (and, if not done right away, the parameter and old behavior eventually removed).

How would this improve snowflake-connector-python?

The interpolate_empty_sequences=False behavior is inconsistent with other database adapters (as demonstrated by both Django and SQLalchemy).

References, Other Background

https://github.com/snowflakedb/snowflake-connector-python/issues/961#issuecomment-984160680 was left open for this change, but automatically closed due to being older than six months.

sfc-gh-aling commented 1 year ago

thanks @timgraham for your feedback.

we will take a look at how other libraries are working and understand how many users are relying on the feature and could be impacted by flipping the flag to weight pros and cons.