snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
585 stars 468 forks source link

SNOW-0000000: Revert pyarrow 13.0.0 dependency. #1935

Closed sfc-gh-jrose closed 5 months ago

sfc-gh-jrose commented 5 months ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This PR removes the maps_as_pydicts parameter that would cause a dependency on pyarrow 13.0.0. This means that maps returned in pandas tables will instead be returned as lists of tuples instead. Users are still free to pass in the maps_as_pydicts parameter to fetch_all_pandas in order to get dictionary objects back instead.