search

snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
568 stars 456 forks source link

Adding changes to include privatelink in hostname from account #1981

Open vinodseshadri opened 1 week ago

vinodseshadri commented 1 week ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR. https://github.com/snowflakedb/snowflake-connector-python/issues/1980 Fixes #1980

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

This adds 'privatelink' in hostname if 'private link' is present in account name. This helps to properly set the host name.

github-actions[bot] commented 1 week ago


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

vinodseshadri commented 1 week ago

I have read the CLA Document and I hereby sign the CLA

sfc-gh-dszmolka commented 1 week ago

i suggest we hold with this PR for now until the underlying issue is fully clarified and root caused