search

snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
601 stars 473 forks source link

SNOW-1571763 fix login timeout read pattern #2022

Closed sfc-gh-aalam closed 3 months ago

sfc-gh-aalam commented 3 months ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #1869

  2. Fill out the following pre-review checklist:

    • [x] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR ensures we use login_timeout instead of _login_timeout internally. login_timeout is a property does type casting to integer.

  4. (Optional) PR for stored-proc connector: NA