snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
585 stars 468 forks source link

[SNOW-1649438] add zstd decompressor in the urllib3 response #2043

Open sfc-gh-dbouassida opened 1 month ago

sfc-gh-dbouassida commented 1 month ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1649438

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

This PR adds support for decompressing zstd (Zstandard) compressed responses in the urllib3 response handler. Key changes:

This enhancement allows the Snowflake connector to properly handle and decompress zstd-compressed responses from the Snowflake service, to improve compatibility and performance.

Resolves: SNOW-1649438

github-actions[bot] commented 1 month ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

sfc-gh-dbouassida commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

sfc-gh-mkeller commented 4 weeks ago

recheck

sfc-gh-mkeller commented 4 weeks ago

The PR looks good by me, how do you plan on testing your feature @sfc-gh-dbouassida ? Can you add some unit tests, or even some integration test? Or is manual testing the best we can do and if so please describe how you have tested this!

@sfc-gh-aling can you guys chime in, please? Dhia's internship is ending soon!