search

snowflakedb / snowflake-connector-python

Snowflake Connector for Python
https://pypi.python.org/pypi/snowflake-connector-python/
Apache License 2.0
601 stars 473 forks source link

SNOW-1650640 changed OCSP fail-open warning message loglevel to warning (from error) #2045

Closed sfc-gh-dszmolka closed 2 months ago

sfc-gh-dszmolka commented 2 months ago

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Relevant to https://github.com/snowflakedb/snowflake-connector-python/issues/2044

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Default behaviour for OCSP is Fail-Open when we cannot do a proper OCSP check; the driver continues to connect to Snowflake while logging a message which is intended to be warning (since the connection still happens). The verbiage of the warning text is clearly reflecting the intention of it being warning - however, we log this warning line at ERROR loglevel instead of WARNING, which apparently causes unnecessary log cluttering in certain scenarios. This small PR aims to change the loglevel for the OCSP Fail-Open message to match the actual verbiage and severity of the event: WARNING

  4. (Optional) PR for stored-proc connector: