snowflakedb / snowflake-ingest-java

Java SDK for the Snowflake Ingest Service -
http://www.snowflake.net
Apache License 2.0
70 stars 57 forks source link

SNOW-987122 Upgrade JDBC to 3.14.5 and Catch new exception type for r… #677

Closed sfc-gh-japatel closed 8 months ago

sfc-gh-japatel commented 8 months ago

…enewing expired S3 token

Changes

sfc-gh-xhuang commented 8 months ago

can close https://github.com/snowflakedb/snowflake-ingest-java/pull/660

sfc-gh-psaha commented 8 months ago

I expect large values test to fail until SNOW-1003775 is fixed but you can work around by changing the tests to read back the length of values instead of the values themselves. Note that gh actions will just crash for these failures and you won't see a proper test failure in the logs. @sfc-gh-japatel

sfc-gh-japatel commented 8 months ago

I expect large values test to fail until SNOW-1003775 is fixed but you can work around by changing the tests to read back the length of values instead of the values themselves. Note that gh actions will just crash for these failures and you won't see a proper test failure in the logs. @sfc-gh-japatel

Ahh yes, thats what I am seeing, FlushServiceTests are running indefinitely and no errors as well! Thanks for pointing it out

sfc-gh-japatel commented 8 months ago

Snyk checks can be ignored since it is complaining pom of e2e library

Screenshot 2024-02-12 at 4 50 07 PM
sfc-gh-tzhang commented 8 months ago

Snyk checks can be ignored since it is complaining pom of e2e library Screenshot 2024-02-12 at 4 50 07 PM

I don't think this can be ignored since we don't see this issue before, and I assume Snyk will keep failing and we will miss real issues if it keeps like this

sfc-gh-xhuang commented 8 months ago

Snyk checks can be ignored since it is complaining pom of e2e library Screenshot 2024-02-12 at 4 50 07 PM

I don't think this can be ignored since we don't see this issue before, and I assume Snyk will keep failing and we will miss real issues if it keeps like this

I had already created an jira last week and assigned to @sfc-gh-jfan to help investigate. SNOW-1045928

sfc-gh-japatel commented 8 months ago

Folks, updated the PR with:

  1. Kept using jdbc 3.13.5, modify test
  2. No special exception handling, catch all exception and retry on very first exception.

Thanks, PTAL!