SNOW-785367: Remove Unused Code - Githubissues

snowflakedb / snowflake-jdbc

Snowflake JDBC Driver

Apache License 2.0

178 stars 170 forks source link

SNOW-785367: Remove Unused Code #1353

Closed awhitford closed 1 year ago

awhitford commented 1 year ago

Discovered a bunch of unused code that can easily be removed...

https://github.com/snowflakedb/snowflake-jdbc/blob/9ab1b43dac8543085bcf1c86cbfcb7cacdaacb3e/src/main/java/net/snowflake/client/core/ResultUtil.java#L31-L32

https://github.com/snowflakedb/snowflake-jdbc/blob/9ab1b43dac8543085bcf1c86cbfcb7cacdaacb3e/src/main/java/net/snowflake/client/core/SFJsonResultSet.java#L30-L31

https://github.com/snowflakedb/snowflake-jdbc/blob/9ab1b43dac8543085bcf1c86cbfcb7cacdaacb3e/src/main/java/net/snowflake/client/jdbc/JsonResultChunk.java#L20

https://github.com/snowflakedb/snowflake-jdbc/blob/9ab1b43dac8543085bcf1c86cbfcb7cacdaacb3e/src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java#L2119

https://github.com/snowflakedb/snowflake-jdbc/blob/9ab1b43dac8543085bcf1c86cbfcb7cacdaacb3e/src/main/java/net/snowflake/client/log/SLF4JJCLWrapper.java#L23-L25

sfc-gh-spanaite commented 1 year ago

Thanks for reporting it @awhitford, PR is being reviewed internally. CC: @sfc-gh-igarish

sfc-gh-spanaite commented 1 year ago

Closing since PR1354 has been merged.