search

snowflakedb / snowflake-sqlalchemy

Snowflake SQLAlchemy
https://pypi.python.org/pypi/snowflake-sqlalchemy/
Apache License 2.0
235 stars 152 forks source link

Snow 1058245 SqlAlchemy 2.0 support #469

Closed sfc-gh-mraba closed 4 months ago

sfc-gh-mraba commented 9 months ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1058245

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
    • [x] I am adding compatibility with SQLAlchemy 2.0

  3. Please describe how your code solves the related issue.

We adapted SnowflakeDialect compatibility with SQLAlchemy 2.0. We added testing jobs with SQLAlchemy 2.0 installed. We moved from tox to hatch.

github-actions[bot] commented 9 months ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

sfc-gh-astus commented 8 months ago

I have read the CLA Document and I hereby sign the CLA

antonrh commented 7 months ago

🚀

nitin-kakkar commented 7 months ago

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

nitin-kakkar commented 7 months ago

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

Would really appreciate if you could provide some timeline. Thanks!!

satniks commented 7 months ago

It looks like implementation is completed and pull request is also approved. Any timelines for merging it and releasing ne version of snowflake-sqlalchemy?

sjhewitt commented 7 months ago

fwiw, I've been running this code in production for a few days and had no issues

sfc-gh-dszmolka commented 7 months ago

hey folks thank you for the interest; please head to the pinned issue https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

@sjhewitt appreciate your comment very much, good to hear the changes are running without major issues !

nitin-kakkar commented 6 months ago

@sfc-gh-mraba - Is there any update on timelines for merging and releasing new version of snowflake-sqlalchemy?

sfc-gh-dszmolka commented 6 months ago

@nitin-kakkar please head to the pinned issue https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

mleot commented 6 months ago

Is this PR going to be merged soon? I saw changes have been approved but not all the checks are complete.

artem-sereda commented 5 months ago

Is this PR going to be merged soon? I saw changes have been approved but not all the checks are complete.

+1

mleot commented 5 months ago

It looks like two actions are stuck but are required before automatically merging. Maybe a maintainer would be able to manually start these two actions?