snowflakedb / snowpark-java-scala

Snowflake Snowpark Java & Scala API
Apache License 2.0
18 stars 21 forks source link

Added Array and Map literals for the java scala codebase #50

Open jbergeroncoveo opened 1 year ago

jbergeroncoveo commented 1 year ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-899560: Support Array and Map type as java/scala Literal #47

  2. Fill out the following pre-review checklist:

    • [:white_check_mark: ] I am adding a new automated test(s) to verify correctness of my new code
    • [:x: ] I am adding new logging messages
    • [:x: ] I am adding a new telemetry message
    • [:x: ] I am adding new credentials
    • [:x: ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

Added a trait TLiteral with 3 children:

  1. ArrayLiteral: Represents an array literal
  2. MapLiteral: Represents a map literal
  3. Literal: Represents everything else.

The Array and Map Literal holds list of literals corresponding to their elements. Those lists are used to generate the SQL for those types recursively.

Pre-review checklist

(For Snowflake employees)

mpetitclerc commented 11 months ago

Is there something else missing to be able to integrate this change?

jeanfrancisroy commented 11 months ago

@sfc-gh-bli any news about this PR? I believe the requested changes were addressed.

mpetitclerc commented 6 months ago

@sfc-gh-bli Is there any reason for this PR to be still open?

I am noticing, there is now a conflict since the PR is open for long time. Is there anything else missing?

Thank you!

sfc-gh-bli commented 6 months ago

@jbergeroncoveo @mpetitclerc We are working on a related feature now. Since there are a lot code conflicts, we will not merge this PR directly. However, we will file a new PR base this PR to implement this feature later this month.