Open jbergeroncoveo opened 1 year ago
Is there something else missing to be able to integrate this change?
@sfc-gh-bli any news about this PR? I believe the requested changes were addressed.
@sfc-gh-bli Is there any reason for this PR to be still open?
I am noticing, there is now a conflict since the PR is open for long time. Is there anything else missing?
Thank you!
@jbergeroncoveo @mpetitclerc We are working on a related feature now. Since there are a lot code conflicts, we will not merge this PR directly. However, we will file a new PR base this PR to implement this feature later this month.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-899560: Support Array and Map type as java/scala Literal #47
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Added a trait
TLiteral
with 3 children:ArrayLiteral
: Represents an array literalMapLiteral
: Represents a map literalLiteral
: Represents everything else.The Array and Map Literal holds list of literals corresponding to their elements. Those lists are used to generate the SQL for those types recursively.
Pre-review checklist
(For Snowflake employees)