snowflakedb / snowpark-java-scala

Snowflake Snowpark Java & Scala API
Apache License 2.0
18 stars 20 forks source link

Create an overload for com.snowflake.snowpark.functions.sum #84

Closed sfc-gh-aherreraaguilar closed 6 months ago

sfc-gh-aherreraaguilar commented 7 months ago

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes # SCT-2665

  2. Fill out the following pre-review checklist:

    • [X] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Added an overload for the sum function which supports a string parameter.

Pre-review checklist

(For Snowflake employees)

sfc-gh-aherreraaguilar commented 6 months ago

@sfc-gh-bli Thanks, I fixed all the comments, please review again.