search

snowflakedb / spark-snowflake

Snowflake Data Source for Apache Spark.
http://www.snowflake.net
Apache License 2.0
211 stars 98 forks source link

Support spark.sql.datetime.java8API.enabled #520

Closed tom-s-powell closed 4 months ago

tom-s-powell commented 1 year ago

Support Spark's spark.sql.datetime.java8API.enabled property when true. This expects dates and timestamp to be java.time.LocalDate and java.time.Instant respectively rather than the java.sql equivalents.

tom-s-powell commented 11 months ago

Any update on when we may be able to get this in?

tom-s-powell commented 11 months ago

I've simplified this using SQLConf.get.datetimeJava8ApiEnabled rather than passing around isJava8Time flag, if that's more preferable as it results in a smaller diff.

tom-s-powell commented 9 months ago

Any update on when this change could be reviewed? Perhaps @sfc-gh-bli you'd be able to take a look?

tom-s-powell commented 8 months ago

@sfc-gh-sshankar @sfc-gh-ema @sfc-gh-bli is this something either of you are able to look at? This is currently blocking our ability to use the Snowflake Spark connector with the latest Java 8 API for dates and timestamps.

tom-s-powell commented 4 months ago

Going to close this given https://issues.apache.org/jira/browse/SPARK-38437.