snowflame0 / AtlasLootClassic_Cata

AtlasLootClassic Cata
https://www.curseforge.com/wow/addons/atlaslootclassic
GNU General Public License v2.0
70 stars 34 forks source link

Random items wrongfully added. #59

Closed Cabro closed 2 weeks ago

Cabro commented 2 weeks ago

Hoping you guys will do a better job than the original devs. There are maaaany low level items that are wrongfully added to the loottables, as if they drop from raid bosses or achievements. Would you please go though these and remove them? image image And the list goes on, there are way more than those 2 example items i showed. /pray

gitenarra commented 2 weeks ago

looks like issues with IDs (item ID number same as achievements or spells), not sure if this can be fixed (or if it will be easy)

snowflame0 commented 2 weeks ago

There are 12,000+ items to go through, so we will have to script it somehow.

I do see that at some point the Wrath sources added achievement IDs as if they were items to the sources list, causing issues like screenshot 2. So, I will figure out what IDs belong to achievements and just remove all of those, as they shouldn't be there. Probably just a bug with the script that they used to parse the lists of items.

The issue with screenshot 1 seems to be because SFK, Deadmines, and several other dungeons were changed and we have temporarily removed them from the Classic dungeons and raids table, but haven't updated the sources list. I'll find a way to fix it, maybe need to remake the old tables.

snowflame0 commented 2 weeks ago

Feel free to add as many screenshots as you find of mistagged items, showing the item ID preferably. It might help figure out all those edge cases.

Looking at the files again, from what you found there are only 3 sets of mistagged items. Old SFK, old Deadmines, and random items with same ID as achievements in Wrath. These are all easy fixes.

If you find something else messed up, let us know here.

snowflame0 commented 2 weeks ago

Ok, should be fixed on next beta. Please open a new issue if you find any more that are incorrect.