snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

Prevent Creative Flying Exploit with GSit plugin #308

Open JustK1009 opened 2 years ago

JustK1009 commented 2 years ago

Is there an existing issue for this?

Type of bug

Exploit

Environment

- Server Version: Paper 1.18.2(git-Paper-246 but tested on multiple paper 1.18.2 versions)
- Shop Version: 1.8.3.5

Server startup log

https://paste.gg/p/anonymous/b434a0f5782a48a0bb54e94d247bd57d

Shop config files

https://paste.gg/p/anonymous/b4aea5d4f3c64d37b1e552fedc74121d

Error log (if applicable)

No response

Bug description

If you do any method in which Shop puts you into creative (For example; /Shop>Search) if someone then sits on your head with the GSit plugin, you are no longer locked to your position. You can fly around anywhere you want.

Steps to reproduce

Steps to reproduce: 1) Install GSit and Shop 2) Make sure sitting on people is enabled in GSit 3) Go into any way that Shop puts you into creative, for this example we will use /shop>search 4) Have someone sit on your head

Some players have found out how to make it so you can kick the person off and you can still fly anywhere but unfortunately I do not have the steps to reproduce this myself.

Expected behaviour

You stay locked in spot and cannot fly around.

Actual behaviour

You can now fly wherever you want.

Other information

No response

snowgears commented 2 years ago

This is not a bug, but a feature request.

Since Shop does not outright cancel the playermoveevent, it would have to implement the GSit API to prevent players from sitting on a player in locked creative mode. https://github.com/Gecolay/GSit/blob/master/core/src/main/java/dev/geco/gsit/api/GSitAPI.java