[BUG] Normal players can crash server with crouch spam creating shops

Cruwzky commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Type of bug

Performance issue or memory leak, Exploit, Other unexpected behaviour

Environment

- Server Version:  Paper 1.18.2
- Shop Version: 1.8.3.6

Server startup log

https://gist.github.com/Cruwzky/a0d4d3dfd7e3e31a685393954ea5bd1a

Shop config files

https://gist.github.com/Cruwzky/17ccc664b3893fdc7d2371b6aa190a4d

Error log (if applicable)

No response

Bug description

A normal player with the permissions to create shops are able to crouch spam click a chest and complete break down the sever TPS and end up crashing the server.

Also in general really bad performance and lagspike when people try to create a shop with crouch and a item in hand. Check out the timings report in other information.

Steps to reproduce

Place chest
Crouch spam create Shop with item in hand

Expected behaviour

The plugin should prevent this from happening.

Actual behaviour

Players crash the server or make the whole server lag.

Other information

https://timings.aikar.co/?id=2628c619465c4e3f9a408dc25ae1b2ac

snowgears commented 2 years ago

Fixed in 1.8.3.7 (in progress)

SladeHazard commented 2 years ago

hey when will this be fixed for 1.12.2?

snowgears commented 2 years ago

I will release a legacy build on the next version. Sorry about the hold up!

snowgears / shopbugs