Allow configurable hopper event listener to update shop state / stock

Plattio commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Type of bug

Other unexpected behaviour

Environment

- Server Version: Paper 1.19
- Shop Version: 1.8.3.7

Server startup log

Privacy issues

Shop config files

https://paste.gg/p/anonymous/2e6445f8e26147138ea58f644cc2ea5d

Error log (if applicable)

No response

Bug description

Hi, when a crate is automatically refilled with a hopper, the sale sign does not update, but only when I open the chest it turns green again (available).

Steps to reproduce

Steps:

Create shop sign (sell)
Place a hopper and chest above the shop chest and fill it with stone

Expected behaviour

Shop sign turns green instead of red

Actual behaviour

Shop sign turns red instead of green (after refill with hopper)

Other information

This bug has existed for several versions, so the log is relatively irrelevant. If this is necessary despite that, I will remove everything necessary. Thanks a lot!

snowgears commented 2 years ago

I used to listen to the hopper event and update shop state but found this to be very heavily server intensive. I may add an option for this so that server owners can choose to turn this back on and accept the performance hit it comes with

Plattio commented 2 years ago

Would be cool! Thank you very much :)

snowgears / shopbugs