search

snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

[BUG] Search icon showing up in "All Shops" menu even if creative selection is disabled #349

Closed zTig3r closed 1 year ago

zTig3r commented 1 year ago

Is there an existing issue for this?

Type of bug

Exploit

Environment

- Server Version: Paper 1.19.2
- Shop Version: 1.8.3.9

Server startup log

https://paste.gg/p/anonymous/a923bd7c22e8437b9495d8d7f35ca056

Shop config files

https://paste.gg/p/anonymous/c38b64e33fe842e38f33c7ad87b26f93

Error log (if applicable)

No response

Bug description

When the option "allowCreativeSelection" in the config.yml is set to false, the compass in the main menu is no longer there, how it should be, but in the new "All Shops" menu the compass is still there and if you click on it you can give yourself every item you want without it being taken away.

Steps to reproduce

  1. Set allowCreativeSelection:false in config.yml
  2. Open the GUI
  3. Click on "All Shops"
  4. Click on the compass
  5. Take items out of the inventory

Expected behaviour

The compass shouldn't be visible inside any menu, when the option is disabled.

Actual behaviour

The compass is still visible in the "All Shops" menu.

Other information

No response

snowgears commented 1 year ago

The behavior of being able to take items is a plugin conflict with another plugin that is uncancelling the event.

I will make sure to add the compass not showing up in the all shops window when that option is off though!

snowgears commented 1 year ago

Fixed in 1.8.4 (in progress)