snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

[BUG] Critical Gamble-Shop Bug (with full Inventory) #379

Closed L3v3lup closed 1 year ago

L3v3lup commented 1 year ago

Is there an existing issue for this?

Type of bug

Exploit, Other unexpected behaviour

Environment

- Server Version: Purpur 1.19.2
- Shop Version: 1.8.4.1

Server startup log

-

Shop config files

-

Error log (if applicable)

-

Bug description

Gamble shops chances can be bypassed by filling the inventory and only keeping an diamond in the inventory. This way, the gamble gets abortet as long as no diamond gets chosen by the gamble algorithm. You need to cancel every attempt to gamble as long as there is no free inventory slot.

Steps to reproduce

  1. Set up a chest with random items and diamonds
  2. Fill your inventory with signs or whatever
  3. Gamble
  4. Result: Only get diamonds

Expected behaviour

Gamble attempts must be stopped with a full inventory

Actual behaviour

Gamble attempts can be made with a full inventory, resulting in getting only "wanted" items

Other information

No response

snowgears commented 1 year ago

Fixed in 1.8.4.2 (in progress)