snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

Gamble Shield item filter #386

Closed DomMerlin closed 1 year ago

DomMerlin commented 1 year ago

Is there an existing issue for this?

Type of bug

Exploit

Environment

- Server Version: 1.19.2 (paper v. 307)
- Shop Version: 1.8.4.2

Server startup log

https://paste.gg/p/anonymous/866fd2a6d838428798aa1fa61e73615b

Shop config files

https://paste.gg/p/anonymous/5774bb51e4c845409cdbaaed92d9549a

Error log (if applicable)

No response

Bug description

Item filter bug: get only the items you really want to get

Steps to reproduce

-> You get the message that there is no space in the inv and nothing is deducted. If you would draw an item from the item lotto, which fits into the inv (because the drawn item "fits" on the stack), you get this item.

Expected behaviour

If the inventory is full, the plugin should directly give the error message that the inventory is full and should NOT start a randomize.

Actual behaviour

Players can select what they get from the gamble shop

Other information

No response

snowgears commented 1 year ago

I am unable to reproduce this bug.

I made a new gamble shop that only has the options for dirt and stone. image

I filled all spaces in my inventory with other items and made sure to put a stack of 1 dirt so that if I got dirt in the gamble output it would be able to fit in my inventory. I am still unable to gamble with the chest. Can you make sure you download the latest file from Spigot? I uploaded a patch fix (still 1.8.4.2 but it contained a bug fix) and deleted the old file

snowgears commented 1 year ago

Marking as fixed until I hear otherwise :)