search

snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

Item Names not showing up #4

Closed JarFiles closed 5 years ago

JarFiles commented 5 years ago

First of all, your Shop plugin is really amazing. But there are a few things which could be improved. It looks like item names aren't working corretly in 1.13.2 yet:

https://imgur.com/ezM3Hox

It just shows an empty field there. And the second thing is my suggestion. Could you please add support for React's (https://www.spigotmc.org/resources/21057/) Culling/Puring of entities? I mean that the shop things don't get removed... And for CMI (https://www.spigotmc.org/resources/3742/) too please.

And I got an error using your plugin with Confiscate (https://www.spigotmc.org/resources/37893/) https://pastebin.com/9NdAucNa. I don't know if it's an error in your plugin or in Confiscate. Anyways I contaced the author of it already and I'm waiting for a response

snowgears commented 5 years ago

As for your feature request, I have reached out to the developer of react to add support, both CMI and Confiscate are not currently planned but welcome to work with the developers if they reach out to me.

EHAndrew commented 5 years ago

I am having the same problem. If it's a basic item, not renamed, it's showing up as [ ] with the default config. There needs to be a way to use [item] and [item type] interchangeably. Maybe default to [item type], but switch to [item] if the item is renamed from its default material.

hamcoremusic commented 5 years ago

I can also confirm that item names are not showing up in 1.13.2!

arizrain1 commented 5 years ago

Can I please ask the status of this bug fix? I have 2 servers in 1.13.2 that have the same issue with no name, if no display is chosen.

SiuanSong commented 5 years ago

Seconding a small status update please. :) Even if it's "haven't gotten there yet."

snowgears commented 5 years ago

haven't gotten there yet ;)

SiuanSong commented 5 years ago

lol thank you!

ghost commented 5 years ago

I check spigot and here everyday to see if this is fixed haha

thunderlight411 commented 5 years ago

Is there any ATE when this is going to be fixed ?

hamcoremusic commented 5 years ago

I hope this gets fixed on a 1.14 update! I love this plugin!!

kittygaming99 commented 5 years ago

I would love an update on this!

BillyGalbreath commented 5 years ago

If you use the 1.14 update with Paper server then the item names will be correct. If you use Spigot or CraftBukkit then a best-guess is used based on limited availability of that information server side. Paper is highly recommended.

kittygaming99 commented 5 years ago

I have tested that and it seems to work perfectly on 1.14.4 paper. I have a survival server on 1.13.2 which can not be updated to the new version however. I would still say this is a bug and if I could at least be told where to start looking if I wanted to fix it myself then that would be great. I understand @BillyGalbreath that you think this bug is caused by a lack of information availability server side. Is there any API or something similar I could use to give myself more options, excluding updating to 1.14?

BillyGalbreath commented 5 years ago

If you use Paper API you can get proper item names using this method

https://papermc.io/javadocs/paper/1.13/org/bukkit/inventory/ItemFactory.html#getI18NDisplayName-org.bukkit.inventory.ItemStack-

Sorry, I can't help further. Life is too busy for backporting fixes to legacy software. Ain't nobody got time for that ;)