search

snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

[BUG] Right-click redeemable items conflict with sell function #406

Closed OllieBellMC closed 2 months ago

OllieBellMC commented 1 year ago

Is there an existing issue for this?

Type of bug

Exploit

Environment

- Server Version: Paper 1.19.3
- Shop Version: Latest - 1.8.4.4

Server startup log

N/A

Shop config files

N/A

Error log (if applicable)

No response

Bug description

Player shops incorrectly handle right-click to redeem items that are sold to them.

Steps to reproduce

  1. Create a shop
  2. Sell a right-click to redeem item, like a voucher, to the shop. Players noticed this issue with grenades on our Prison server.
  3. Notice that you will keep the right-click item and also receive the money from the shop

Expected behaviour

Players should lose the item that they are selling to the shop and receive the money.

Actual behaviour

Players keep the item that they are selling to the shop and receive the money.

Other information

No response

OstlerDev commented 2 months ago

This issue should be fixed now I believe. If this is still an issue for you please feel free to create a new bug report!