OstlerDev
commented
1 month ago I have revamped our WorldGuard integration so that it will now properly respect the flags passthrough, build, chest-access. These checks will now always be performed, and are checked first before the allow-shop flag. This should fix the bug you were running into!
The allow-shop flag has now been made optional!
-
(Default) Ignore Flag:
- Allow shops everywhere that you can build and access chests, and ignore the
allow-shopflag completely. - Verify
hookWorldGuardisfalsein yourconfig.ymlfile
- Allow shops everywhere that you can build and access chests, and ignore the
-
Require Flag:
- Completely disallow shops in all regions that do not explicitly have
allow-shop: ALLOW. - Set
hookWorldGuardtotruein yourconfig.ymlfile
- Completely disallow shops in all regions that do not explicitly have
Is there an existing issue for this?
Type of bug
Other unexpected behaviour
Environment
Server startup log
If you insist you need this I will get it to you.
Shop config files
If you insist you need this I will get it to you.
Error log (if applicable)
No response
Bug description
The SignChangeEvent doesnt check if it gets canceled, allowing someone, with how signs edit now even when canceled, to create a shop in a location where they cannot build, or truly edit the signs.
Steps to reproduce
Have a plugin that would cancel the sign editing, lets say worldguard for this. Interact with the sign Write out the shop creation
Expected behaviour
It should not go to shop initialization
Actual behaviour
It does go to shop initialization, and player can effectively lock a chest where they cannot build.
Other information
No response