snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

[BUG] NullPointerException: Profile name must not be null on updating to 1.20.2 #417

Closed DrPepplies closed 2 months ago

DrPepplies commented 1 year ago

Is there an existing issue for this?

Type of bug

Compatibility issue, Error in console

Environment

- Server Version: Paper v1.20.2 (build 234, latest)
- Shop Version: v1.8.4.5

Server startup log

It's almost entirely the error

Shop config files

https://paste.gg/p/anonymous/c98bcca929c743f09207e8f8bb76656c

Error log (if applicable)

https://paste.gg/p/anonymous/10af753e0a324fa784aac7b312db500b

Bug description

Shop works perfectly on 1.20.1 with Shop 1.8.4.4, but on upgrading to 1.20.2 and the new version of Shop, this error spams the console thousands of times.

Haven't changed any config or setup between the updates. No other updated plugins are breaking so I don't think it's a general 1.20.2 problem.

I've included two versions of the error, it logs the first one occasionally but the second one tons. I assume it's the same thing but is happening in a repeating task.

All the shops say null on the owner line, and the chests can be opened by anybody.

Steps to reproduce

Don't know, started happening on Minecraft update.

Expected behaviour

No error

Actual behaviour

Error

Other information

No response

DrPepplies commented 1 year ago

I've experimented a bit more to try and find out why this happens, I think it's unable to resolve UUIDs for people's usernames anymore? When I create my own shops on the server, they work fine. When I import only my own data from the 1.20.1 server it seems to work fine (even before I log in). But then if I try pulling other people's data files across, even one single file with only one shop in it, the error happens and the shop says "null" on the owner sign.

I don't think I've changed anything related to that.

DrPepplies commented 1 year ago

I think I've been able to repair this by restoring the playerdata folder from a backup. Or at least, doing that has made it stop happening. I'll leave this open in case it's still a bug you want to look into or patch but feel free to close if you can't reproduce.

OstlerDev commented 2 months ago

I was unable to replicate the error, so I am going to close this for now, feel free to reopen/log a new bug report it if it becomes an issue again