[BUG] allowPartialSales (barter shop)

Yukylyu commented 10 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Type of bug

Exploit

Environment

- Server Version: 1.20.1
- Shop Version: 1.8.4.4

Server startup log

-

Shop config files

allowPartialSales: true

Error log (if applicable)

No response

Bug description

Hi, Same problem as this ticket: https://github.com/snowgears/shopbugs/issues/380

Steps to reproduce

make a barter shop (example 10 diamond vs 32 stone)
have 3 stones in inventory = 1 diamond
to exchange

Expected behaviour

the shop barter should say that there are not enough items to exchange.

Actual behaviour

the shop will give the diamond for 3 stones...

For a sale or purchase ok but it should not work for a shop barter.

Other information

No response

OstlerDev commented 1 month ago

The Transaction handler has been completely rewritten for v1.9.1.0 to support partial sales for all shop types, and clean up the internal transaction code significantly. This bug has been fixed in the upcoming release of v1.9.1.0!

OstlerDev commented 1 month ago

Released 1.9.1.0

snowgears / shopbugs