snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

[BUG] checkItemDurability flag broke shops #436

Closed Shepelzz closed 4 days ago

Shepelzz commented 1 month ago

Is there an existing issue for this?

Type of bug

Bug

Environment

- Server Version: 1.21
- Shop Version: 1.9.0.1

Server startup log

https://paste.gg/p/anonymous/4b4dcb34f96a440d8772507c69490ff4

Shop config files

https://paste.gg/p/anonymous/f505ea1c9481418d84c034214e289b63

Error log (if applicable)

No response

Bug description

When i set checkItemDurability to FALSE, all my existing shops are out of stock, no matter is there enough stock or not.

Steps to reproduce

  1. Run plugin with checkItemDurability: true
  2. Create sell stone shop and fill chest with stone. Shop is "green"
  3. Change checkItemDurability to false and reload plugin or server.
  4. try to look into your chest and shop will be updated as out of stock.

Expected behaviour

Shop should work

Actual behaviour

Shop not works

Other information

No response

Shepelzz commented 3 weeks ago

@snowgears any response?

OstlerDev commented 3 weeks ago

I will look into this, it is likely an issue with the NBT data changes in 1.21. Hopefully this fix will be included in v1.9.1.0, otherwise it will likely be in v1.9.1.1

OstlerDev commented 2 weeks ago

Verified and Fixed in upcoming release 1.9.1.0