search

snowgears / shopbugs

Shop bug tracker
8 stars 4 forks source link

[BUG] Players can open other shops #451

Open Xmike24 opened 1 month ago

Xmike24 commented 1 month ago

Is there an existing issue for this?

Type of bug

Exploit

Environment

- Server Version: Paper 1.21.1
- Shop Version: 1.9.1.2

Server startup log

https://paste.gg/p/anonymous/979c645afaaf440da021cdb31eb7379a

Shop config files

https://paste.gg/p/anonymous/455fd53bedf04c7fa175c9136bb114ca

Error log (if applicable)

No response

Bug description

Hey, players can use shift right click to open other players' shop chests if the area is not otherwise secured. You can also take items from the chest. I found out that it is because of this line:

cycleShopDisplay: 'NONE'

If I leave it on SHIFT_RIGHT_CLICK_CHEST the bug doesn't occur.

Steps to reproduce

Right Shift Chest

Expected behaviour

You shouldn't be able to open the chest.

Actual behaviour

Players can steal items from shops.

Other information

No response

OstlerDev commented 1 month ago

Issue has been verified and fixed, it will be released in the next update. For now until the next version is out, leave the config setting as default and just don't assign the permission to players and they won't be able to perform the cycle display action.