search

snowgoon88 / TW5-extendedit

Try to extend the editor of TiddlyWiki5
MIT License
38 stars 10 forks source link

Plugin does not prevent propagation of event from framed editor #18

Closed saqimtiaz closed 3 years ago

saqimtiaz commented 4 years ago

keydown events - such as enter to select an autocomplete entry - are still propagated to the main document from the framed editor (which is inside an iframe). This is due to some special handling of events inside the iframe in TW, by which events from the iframe are propagated to the parent document. This causes clashes with other plugins that also react to keyboard events.

I will submit a pull request in a few days that works around this, so that events are only propagated further if not handled by the autocomplete.

snowgoon88 commented 4 years ago

Oh, ok. I'll let you explore that... BTW, would you like to be a collaborator on this project ? Snow

saqimtiaz commented 4 years ago

If that would be helpful, sure you can add me as a collaborator. I don't expect to work on it more after this bug fix unless something else comes up.

snowgoon88 commented 4 years ago

Sorry, I was on vacation. I'll set you up as collaborator. Snow

snowgoon88 commented 3 years ago

I guess last commit (721b122d502ddb15b1ac6b20d71770cf5c9759c3) fixed that. We could close, no ?

saqimtiaz commented 3 years ago

Yes, I should have closed it.