snowgoon88 / TW5-extendedit

Try to extend the editor of TiddlyWiki5
MIT License
38 stars 10 forks source link

Integrate edit-comptext in rich text editor #29

Open JoostvandenDool opened 2 years ago

JoostvandenDool commented 2 years ago

Dear Snowgoon88,

During the Christmas break I worked on a rich text editor for TW4 see: https://github.com/JoostvandenDool/TW-Plugins One thing I am missing is the great functionality of edit-comptext to have link completion. Is it somehow possible to integrate your plugin in the riich text editor?

I tried to understand the code but do not understand it enough to see how integration could work.

Kind regards,

Joost

snowgoon88 commented 2 years ago

Hello Joost,

I had a quick look at your RTEditor github demo. I managed to get the comptexteditor working with your tab or shift+tab key forcing the "Type" of a widget to be "text/vnd.tiddlywiki" (it is the field below the editing area). This is not very ergonomic as you have to "save" the tiddler (click the "Confirm change to this tiddler" button) and then re-edit it.

Still, I have some questions about your code. I had a quick look at RTEditor and I wonder: 1) how are you able to say to TW5 that edited tiddler will use your RTEditorWidget ? Is it a kind of overwriting of the "classical" Toolbar Editor of TW5 ? 2) where do the various "undo", "redo", "removeFormat" etc command used in Toolbar2 come from ?

This is only because I am very curious about all that and because I'd like to better understand TW5 and your plugin.

Besides, I do not know if it could help you, but there is a "newer" version of the completion plugin where Saqimiatz eased the intergration of the completion plugin with the basic editors of TW5 (SimpleEditorEngine and FramedEditorEngine). This newer version could maybe ease its use in your case.

Tell me if I can help you further, Alain / Snow

Le sam. 8 janv. 2022 à 11:24, JoostvandenDool @.***> a écrit :

Dear Snowgoon88,

During the Christmas break I worked on a rich text editor for TW4 see: https://github.com/JoostvandenDool/TW-Plugins One thing I am missing is the great functionality of edit-comptext to have link completion. Is it somehow possible to integrate your plugin in the riich text editor?

I tried to understand the code but do not understand it enough to see how integration could work.

Kind regards,

Joost

— Reply to this email directly, view it on GitHub https://github.com/snowgoon88/TW5-extendedit/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL3QVDEM5T77A6WBNJFR2LUVAGD7ANCNFSM5LQOWOZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

JoostvandenDool commented 2 years ago

Dear Alain,

Thank you for looking into this. To redirect TW5 to my widget I made a view template which uses reveal to only show the content when the tag is Note see: https://github.com/JoostvandenDool/TW-Plugins/blob/main/RTEditor/RTViewTemplate.tid In the CSS i hide the standard body viewtemplate

The commands I use come from this example which is the basis of the editor: https://github.com/JoostvandenDool/TW-Plugins/blob/main/RTEditor/RTViewTemplate.tid

I integrated your plugin in the widget this weekend but got an error regarding determining the lastposition. I will try further this weekend.

Kind regards,

Joost

On Sun, Jan 9, 2022 at 7:59 PM snowgoon88 @.***> wrote:

Hello Joost,

I had a quick look at your RTEditor github demo. I managed to get the comptexteditor working with your tab or shift+tab key forcing the "Type" of a widget to be "text/vnd.tiddlywiki" (it is the field below the editing area). This is not very ergonomic as you have to "save" the tiddler (click the "Confirm change to this tiddler" button) and then re-edit it.

Still, I have some questions about your code. I had a quick look at RTEditor and I wonder: 1) how are you able to say to TW5 that edited tiddler will use your RTEditorWidget ? Is it a kind of overwriting of the "classical" Toolbar Editor of TW5 ? 2) where do the various "undo", "redo", "removeFormat" etc command used in Toolbar2 come from ?

This is only because I am very curious about all that and because I'd like to better understand TW5 and your plugin.

Besides, I do not know if it could help you, but there is a "newer" version of the completion plugin where Saqimiatz eased the intergration of the completion plugin with the basic editors of TW5 (SimpleEditorEngine and FramedEditorEngine). This newer version could maybe ease its use in your case.

Tell me if I can help you further, Alain / Snow

Le sam. 8 janv. 2022 à 11:24, JoostvandenDool @.***> a écrit :

Dear Snowgoon88,

During the Christmas break I worked on a rich text editor for TW4 see: https://github.com/JoostvandenDool/TW-Plugins One thing I am missing is the great functionality of edit-comptext to have link completion. Is it somehow possible to integrate your plugin in the riich text editor?

I tried to understand the code but do not understand it enough to see how integration could work.

Kind regards,

Joost

— Reply to this email directly, view it on GitHub https://github.com/snowgoon88/TW5-extendedit/issues/29, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAL3QVDEM5T77A6WBNJFR2LUVAGD7ANCNFSM5LQOWOZA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/snowgoon88/TW5-extendedit/issues/29#issuecomment-1008354775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL4BDOAORGDFBXBGT2PXZADUVHLITANCNFSM5LQOWOZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>