search

snowie2000 / mactype

Better font rendering for Windows.
https://mactype.net
GNU General Public License v3.0
9.96k stars 441 forks source link

The latest version does not support Microsoft Windows Terminal #607

Open hopana opened 5 years ago

hopana commented 5 years ago

The mactype latest beta6 vertion does not render the font in Microsoft Windows Terminal (Preview).

Windows Terminal: https://github.com/microsoft/terminal

snowie2000 commented 5 years ago

We don't have enough information on how those win32 UWP apps are created from their parent processes. So they are not supported so far.

Help is warmly appreciated to get the UWP support improved!

ahaseeb04 commented 3 years ago

@snowie2000 Is there an update on this?

gfody commented 2 years ago

if you launch C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.11.3471.0_x64__8wekyb3d8bbwe\wt.exe then it gets hooked correctly. still a problem with other apps, like Musicbee for example.

lhecker commented 1 year ago

I work on Windows Terminal and I've found that Windows Terminal Preview 1.18 started crashing when MacType is used. This appears to happen because it calls ID2D1Device4::SetMaximumColorGlyphCacheMemory and EasyHook seems to do something wrong somehow. It's especially easy to reproduce if the Basic checks in the Application Verifier are enabled. I'm not entirely sure how I should fix the issue, since it's technically not an issue we caused, but on the other hand...

sangiye0 commented 7 months ago

When I enable the new text renderer("AtlasEngine") option in Windows Terminal 1.18, terminal often crashes. They are planning to make this option enabled as default in future versions(https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release/).

snowie2000 commented 7 months ago

Great, if I can reproduce it, I can fix it

On Sat, Feb 17, 2024 at 2:05 PM snowpine @.***> wrote:

When I enable the new text renderer("AtlasEngine") option in Windows Terminal 1.18, terminal often crashes. They are planning to make this option enabled as default in future versions([( https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release/)] ).

— Reply to this email directly, view it on GitHub https://github.com/snowie2000/mactype/issues/607#issuecomment-1949737834, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZY3FKERS4OLV3F2BOHRHLYUBCCHAVCNFSM4IXLHRNKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJUHE3TGNZYGM2A . You are receiving this because you were mentioned.Message ID: @.***>

sangiye0 commented 7 months ago

I made a short demo.

While MacType service is working, I changed the renderer settings in Terminal. And I opened a new tab and the whole program is closed after a few seconds. Also, crash happens when I start a new Terminal. I am not sure It actually is related with MacType, but it looks like that it disappears when I disable MacType or AtlasEngine.

demo

lhecker commented 7 months ago

@snowie2000 The PR that I sent you last year fixes this bug (#938). @sangiye0 The fix is in the latest RC: https://github.com/snowie2000/mactype/releases/tag/v1.2023.5.31

snowie2000 commented 7 months ago

@lhecker I see. I just don't know that this bug is also related. great thanks!

I can confirm with my terminal testing that the new rendering engine works normally with the latest RC version.