snowl / LegendaryClient

Custom League of Legends client. No longer in development.
MIT License
43 stars 30 forks source link

UI config for server and language #21

Closed GodLesZ closed 10 years ago

GodLesZ commented 10 years ago

I'm playing on EUW using language de_DE, but the client pulls hardcoded from NA using en_US.

After changing the server config, (all?) client files needs to be reloaded. After changing the language config, gameStates-file needs to be reloaded.

snowl commented 10 years ago

Yes localization is planned for after release. It will support full localization (both in-game and in client)

GodLesZ commented 10 years ago

Sounds good. shouldn't be that hard, most access comes from RiotPatcher class. Just the access to the localized gameStats file should be wrapped because its used multiple times with hardocded language.

I can create a pull request for the abstraction, but never worked with WCF so the UI part could be a problem.

snowl commented 10 years ago

The problem comes from the actual patching. Currently it retrieves it from your installation (which is pretty easy), but when I implement patching it becomes more difficult. I also need to localize strings in the client and some english based stuff, so that's why I am waiting until it is finished to implement it.

GodLesZ commented 10 years ago

Localized strings in the client itself should be handled by .NET rersources IMO. .NET already implements localization out of the box: http://msdn.microsoft.com/en-us/library/dd882554(v=vs.95).aspx

As for the patching, i couldnt help IMO. I never invastigated the LoL structure or there patching service yet. On a clean installation, after downloading there offical base client, all files were loading (single or as a archive, dont know) which tells me, they have a list of needed files. Also there "restore" function in the patcher settings checks "core files", which tells me too, they got a file list. Maybe its possible to catch the request of the patcher to the file list and downloading everything from there server.