a few things - Githubissues

ashame commented 10 years ago

logging in gets an error with auth half the time
starting a game in a custom map lobby crashes constantly with more than two players
chat always shows everyone offline

snowl commented 10 years ago

Giving the error messages would be helpful... since I can't reproduce any of these

ashame commented 10 years ago

Login is just "Unable to get auth key" which I assume to be communication errors between the client / riot's servers.

For the chat, it shows everyone offline - however I can still message myself from the league client. http://puu.sh/671mI.jpg - no error messages whatsoever.

Receiving invites also crashes client - http://puu.sh/671ug.jpg

I'll try to get a friend to help reproduce the other error asap. Great job with the client though. (:

snowl commented 10 years ago

Can you run it in visual studio so I can see the exception please? And when you get the auth error click on the error message and press CTRL+A then CTRL+C and paste the error message into here.

thanks ^^

ashame commented 10 years ago

Login error: http://puu.sh/677pp.txt

Invites have seem to fixed themselves somehow - might've been something I did or didn't do earlier, although accepting one to a custom shows the entire lobby as invisible. With the lobby thing, it worked fine again when I tested it with a friend running the regular client, however it constantly crashed when I tried it with my other friend who was also running LegendaryClient. Until I get the chance to test it again, I'm gonna assume that it only happens when there's more than one person running the client in lobby.

Edit: On a second note, logout is broken when you have autologin ticked.

Edit2: Queueing for bot games as a premade team works - http://puu.sh/67dPf.jpg - http://puu.sh/67dX7.png had to modify a bit of the code, as you can grab the bot selected champ from champion select - it shows the same as normal players.

snowl commented 10 years ago

thx :) login is broken when there is a queue.I'll try fix the other issues when I get back. if you can recreate the invite errothat would be mint

ashame commented 10 years ago

yeah, the queue is what I assumed. I'll try to recreate the invite error as soon as my friend get on. on a second note, changing summoner icon is broken aswell.

snowl commented 10 years ago

does it giveyou an error or just not update? or not update for other people?

ashame commented 10 years ago

doesn't give an error, doesn't update or close the icon select client side, however it seems to update server side as relogging into the actual client showed me the icon I changed to.

snowl commented 10 years ago

that is super weird...

ashame commented 10 years ago

I've just tested it again - it always updates server side without fail, however client side it only updates the first time around, if you haven't switch to any other pages beforehand.

snowl commented 10 years ago

Thanks :) I can't test since I don't have a computer herebutonce I get home I'll try and replicate it

ashame commented 10 years ago

Alright. I'm just trying to go through as much as I can here. I don't know that much C# myself, but coming from a Java background, I can at least understand the gist of it.

On Thu, Jan 2, 2014 at 3:11 PM, David Diaz notifications@github.com wrote:

Thanks :) I can't test since I don't have a computer herebutonce I get home I'll try and replicate it

— Reply to this email directly or view it on GitHubhttps://github.com/Snowl/LegendaryClient/issues/38#issuecomment-31493277 .

                From,
                      Nathan

Alternate Email: nathansliu@gmail.com

shalzuth commented 10 years ago

Issue is with when you cache the pages when switching pages, the pointer to ProfileImage from MainPage gets lost. Silly pages. This could be a fix. I will pull request it soon. https://github.com/shalzuth/LegendaryClient/commit/8a110d9ae1f9d7472d1cf5d16285f383c6927747

ashame commented 10 years ago

Yeah, when I took a look at the code, I had my suspicions that it was with the caching. Didn't have much of a clue how to fix it though. :x

On Fri, Jan 3, 2014 at 6:14 AM, shalzuth notifications@github.com wrote:

Issue is with when you cache the pages when switching pages, the pointer to ProfileImage from MainPage gets lost. Silly pages. This could be a fix. I will pull request it soon. shalzuth@8a110d9https://github.com/shalzuth/LegendaryClient/commit/8a110d9ae1f9d7472d1cf5d16285f383c6927747

— Reply to this email directly or view it on GitHubhttps://github.com/Snowl/LegendaryClient/issues/38#issuecomment-31524470 .

                From,
                      Nathan

Alternate Email: nathansliu@gmail.com

snowl / LegendaryClient

a few things #38