search

snowleopard / alga

Algebraic graphs
MIT License
717 stars 68 forks source link

Add bipartite adjacency maps #207

Closed vasalf closed 5 years ago

snowleopard commented 5 years ago

@vasalf Many thanks for the PR! I've left a bunch of comments, please have a look.

snowleopard commented 5 years ago

@vasalf There is a test failure:

============ Eq (Bipartite.AdjacencyMap a b) ============
Test failure:
    (x == y) == ((leftAdjacencyMap x == rightAdjacencyMap x) && (leftAdjacencyMap y == rightAdjacencyMap y))
*** Failed! Falsified (after 3 tests):
empty
vertices [-2] [-2]

The full log is here: https://travis-ci.org/snowleopard/alga/jobs/550349421

Please investigate.

vasalf commented 5 years ago

@vasalf There is a test failure:

============ Eq (Bipartite.AdjacencyMap a b) ============
Test failure:
    (x == y) == ((leftAdjacencyMap x == rightAdjacencyMap x) && (leftAdjacencyMap y == rightAdjacencyMap y))
*** Failed! Falsified (after 3 tests):
empty
vertices [-2] [-2]

The full log is here: https://travis-ci.org/snowleopard/alga/jobs/550349421

Please investigate.

@snowleopard Thanks for pointing it out! It turned out that the test was wrong. I fixed it. Hope it will pass this time (it passes on my machine, but we know that means nothing).

I also fixed a small bug in Show instance.

snowleopard commented 5 years ago

Thanks, merged!