search

snowleopard / alga

Algebraic graphs
MIT License
717 stars 68 forks source link

Add `Monoid` and `Semigroup` instances #276

Closed ocharles closed 3 years ago

ocharles commented 3 years ago

Fixes #269.

snowleopard commented 3 years ago

@ocharles Many thanks for the PR! Alas, CI fails on a couple of GHC versions, most likely we need to do a dance with imports and/or CPP.

ocharles commented 3 years ago

Do you really care about 8.0 and 8.2? You might be inventing more work than you need to, that's quite the range of support! But that's for another issue, I'll get this all building with CI tomorrow (along with those instance comments) :+1:

snowleopard commented 3 years ago

Yeah, I think you are right and I should just stop supporting 8.0 and 8.2.

Shall we keep this PR as is for now and switch to dropping 8.0 and 8.2 to avoid unnecessary work? Either way is fine for me.

ocharles commented 3 years ago

@snowleopard If you're planning to drop support for 8 & 8.2 then I won't make any changes - I'm always one for doing the least amount of work possible! :laughing: I will add the Haddock comments though.

snowleopard commented 3 years ago

@ocharles Done!

ocharles commented 3 years ago

@snowleopard ok, documentation added

snowleopard commented 3 years ago

@ocharles Thanks, merged! Just tweaked one of the comments.